Skip to content

ref(data_export): add path param to gcs_data_sink #101993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2025
Merged

ref(data_export): add path param to gcs_data_sink #101993

merged 3 commits into from
Oct 24, 2025
+18 −3

Conversation

@viglia
Copy link
Contributor

@viglia viglia commented Oct 23, 2025

This allows us to specify a prefix under the destination bucket when transferring data from another bucket.

This will make it possible to use the same bucket across several event types and specify the right prefix for each.

@viglia
ref(data_export): add path param to gcs_data_sink
ade998c 
This allows us to specify a prefix under the destination bucket when
transferring data from another bucket.

This will make it possible to use the same bucket across several event
types and specify the right prefix for each.
@viglia viglia requested review from a team as code owners October 23, 2025 11:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2025
@getsentry getsentry deleted a comment from cursor bot Oct 23, 2025
bruno-garcia
bruno-garcia approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But prediction didn't pick up anything so I guess we're good to go :)
I'd tag Colton as the author of these scripts and he's on a 3 months leave.

The change seems simple enough just adding a path prefix, so rubberstamping

@viglia viglia merged commit ccf56b7 into master Oct 24, 2025
69 checks passed
@viglia viglia deleted the viglia/ref/create_transfer_job-add-path-param branch October 24, 2025 06:56
priscilawebdev pushed a commit that referenced this pull request Oct 28, 2025
@viglia @priscilawebdev
ref(data_export): add path param to gcs_data_sink (#101993)
f6563d7 
This allows us to specify a prefix under the destination bucket when
transferring data from another bucket.

This will make it possible to use the same bucket across several event
types and specify the right prefix for each.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viglia @bruno-garcia