Skip to content

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Dec 14, 2025

This happens on every pageload, regardless of what locale is chosen. The page does render/rerender in other languages according to what the user has selected, so this isnt doing anything useful

Test Plan:

  1. Go to https://sentry.io/settings/account/details/ and change your language settings.
    • Mine started in English, I switched to German
  2. Do a full pageload (we don't async load language files if that preference changes)
  3. Notice that the warning is in the console
  4. Notice that the page is rendering with the chosen language

Now in step 4 the warning is gone!

This happens on every pageload, regardless of what locale is chosen. The page does render/rerender in other languages according to what the user has selected, so this isnt doing anything useful
@ryan953 ryan953 requested a review from a team as a code owner December 14, 2025 22:07
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 14, 2025
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104933      +/-   ##
===========================================
- Coverage   80.52%    80.41%   -0.12%     
===========================================
  Files        9398      9393       -5     
  Lines      405708    403384    -2324     
  Branches    25923     25923              
===========================================
- Hits       326710    324382    -2328     
- Misses      78558     78562       +4     
  Partials      440       440              

@ryan953 ryan953 merged commit 980fbeb into master Dec 15, 2025
50 checks passed
@ryan953 ryan953 deleted the ryan953/rm-locale-warning branch December 15, 2025 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants