Skip to content

ref(ui2): improve space() deprecation notice #95883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+61 −1
Open

ref(ui2): improve space() deprecation notice #95883

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58966b1
ref(ui2): improve `space()` deprecation notice
natemoo-re Jul 18, 2025
9ba4df9
Merge branch 'master' into ui2/nm/space-deprecation
natemoo-re Jul 18, 2025
f9496bf
fix(theme): improve space overload
natemoo-re Jul 18, 2025
701a8a9
Merge branch 'master' into ui2/nm/space-deprecation
natemoo-re Jul 18, 2025
159f68c
Merge branch 'master' into ui2/nm/space-deprecation
natemoo-re Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion static/app/styles/space.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,67 @@ const SPACES = {
export type ValidSize = keyof typeof SPACES;

/**
* @deprecated prefer using `theme.space`
* @deprecated prefer `theme.space['2xs']`
*/
function space<S extends 0.25>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space.xs`
*/
function space<S extends 0.5>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space.sm`
*/
function space<S extends 0.75>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space.md`
*/
function space<S extends 1>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space.lg`
*/
function space<S extends 1.5>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space.xl`
*/
function space<S extends 2>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space['2xl']`
*/
function space<S extends 3>(size: S): (typeof SPACES)[S];
/**
* @deprecated prefer `theme.space['3xl']`
*/
function space<S extends 4>(size: S): (typeof SPACES)[S];
/**
* @deprecated replace with `theme.space.*` value from the
*
*
* | before | after | value |
* | ------ | ------ | -------------------- |
* | | `none` | `0px` (new!) |
* | `0.25` | `2xs` | `2px` |
* | `0.5` | `xs` | `4px` |
* | `0.75` | `sm` | `6px` |
* | `1` | `md` | `8px` |
* | `1.5` | `lg` | `12px` |
* | `2` | `xl` | `16px` |
* | `3` | `2xl` | `24px` (from `20px`) |
* | `4` | `3xl` | `32px` (from `30px`) |
*/
function space<S extends ValidSize>(size: S): (typeof SPACES)[S];
/**
* @deprecated replace with `theme.space.*`
* | before | after | value |
* | ------ | ------ | -------------------- |
* | | `none` | `0px` (new!) |
* | `0.25` | `2xs` | `2px` |
* | `0.5` | `xs` | `4px` |
* | `0.75` | `sm` | `6px` |
* | `1` | `md` | `8px` |
* | `1.5` | `lg` | `12px` |
* | `2` | `xl` | `16px` |
* | `3` | `2xl` | `24px` (from `20px`) |
* | `4` | `3xl` | `32px` (from `30px`) |
*/
function space<S extends ValidSize>(size: S): (typeof SPACES)[S] {
return SPACES[size];
Expand Down
Loading