Skip to content

fix(buffered_segments): Skip producing outcomes if --skip-produce is set #95922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

untitaker
Copy link
Member

Relay currently still produces these outcomes for as long as it writes
to snuba-items. Whoever writes to snuba-items should also write to
outcomes.

Relay currently still produces these outcomes for as long as it writes
to snuba-items. Whoever writes to snuba-items should also write to
outcomes.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 18, 2025
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #95922      +/-   ##
==========================================
- Coverage   87.78%   87.74%   -0.05%     
==========================================
  Files       10589    10583       -6     
  Lines      610020   609760     -260     
  Branches    23990    23949      -41     
==========================================
- Hits       535483   535010     -473     
- Misses      74253    74466     +213     
  Partials      284      284              

@untitaker untitaker marked this pull request as ready for review July 21, 2025 08:22
@untitaker untitaker requested review from a team as code owners July 21, 2025 08:22
@untitaker untitaker enabled auto-merge (squash) July 21, 2025 08:23
@untitaker untitaker merged commit 9f31644 into master Jul 21, 2025
93 of 95 checks passed
@untitaker untitaker deleted the skip-produce-outcomes branch July 21, 2025 17:27
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
…set (#95922)

Relay currently still produces these outcomes for as long as it writes
to snuba-items. Whoever writes to snuba-items should also write to
outcomes.
Copy link

sentry-io bot commented Jul 21, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants