wip: update queries to fetch the new metric

src/sentry/release_health/base.py

@@ -36,6 +36,8 @@
     "crash_free_rate(user)",
     "anr_rate()",
     "foreground_anr_rate()",
+    "unhandled_rate(session)",
+    "unhandled_rate(user)",
 ]
 
 GroupByFieldName = Literal[
@@ -182,6 +184,8 @@ class ReleaseHealthOverview(TypedDict, total=False):
     duration_p50: float | None
     duration_p90: float | None
     stats: Mapping[StatsPeriod, ReleaseHealthStats]
+    sessions_unhandled: int
+    handled_sessions: float | None
 
 
 class CrashFreeBreakdown(TypedDict):

src/sentry/release_health/metrics.py

@@ -780,6 +780,11 @@ def _get_session_by_status_for_overview(
 
         select = [
             MetricField(metric_mri=SessionMRI.ABNORMAL.value, alias="abnormal", op=None),
+            MetricField(
+                metric_mri=SessionMRI.UNHANDLED.value,
+                alias="unhandled",
+                op=None,
+            ),
             MetricField(metric_mri=SessionMRI.CRASHED.value, alias="crashed", op=None),
             MetricField(metric_mri=SessionMRI.ALL.value, alias="init", op=None),
             MetricField(
@@ -820,7 +825,13 @@ def _get_session_by_status_for_overview(
             release = by.get("release")
 
             totals = group.get("totals", {})
-            for status in ["abnormal", "crashed", "init", "errored_preaggr"]:
+            for status in [
+                "abnormal",
+                "unhandled",
+                "crashed",
+                "init",
+                "errored_preaggr",
+            ]:
                 value = totals.get(status)
                 if value is not None and value != 0.0:
                     ret_val[(proj_id, release, status)] = value
@@ -1037,10 +1048,13 @@ def get_release_health_data_overview(
             if not has_health_data and summary_stats_period != "90d":
                 fetch_has_health_data_releases.add((project_id, release))
 
+            sessions_unhandled = rv_sessions.get((project_id, release, "unhandled"), 0)
             sessions_crashed = rv_sessions.get((project_id, release, "crashed"), 0)
 
             users_crashed = rv_users.get((project_id, release, "crashed_users"), 0)
 
+            sum_unhandled = sessions_unhandled + sessions_crashed
+
             rv_row = rv[project_id, release] = {
                 "adoption": adoption_info.get("adoption"),
                 "sessions_adoption": adoption_info.get("sessions_adoption"),
@@ -1051,10 +1065,14 @@ def get_release_health_data_overview(
                 "total_sessions": total_sessions,
                 "total_users": total_users,
                 "has_health_data": has_health_data,
+                "sessions_unhandled": sessions_unhandled,
                 "sessions_crashed": sessions_crashed,
                 "crash_free_users": (
                     100 - users_crashed / total_users * 100 if total_users else None
                 ),
+                "handled_sessions": (
+                    100 - sum_unhandled / float(total_sessions) * 100 if total_sessions else None
+                ),
                 "crash_free_sessions": (
                     100 - sessions_crashed / float(total_sessions) * 100 if total_sessions else None
                 ),
@@ -1063,6 +1081,7 @@ def get_release_health_data_overview(
                     rv_errored_sessions.get((project_id, release), 0)
                     + rv_sessions.get((project_id, release, "errored_preaggr"), 0)
                     - sessions_crashed
+                    - sessions_unhandled
                     - rv_sessions.get((project_id, release, "abnormal"), 0),
                 ),
                 "duration_p50": None,
@@ -1427,6 +1446,9 @@ def get_project_release_stats(
                 MetricField(
                     metric_mri=SessionMRI.CRASHED_USER.value, alias="users_crashed", op=None
                 ),
+                MetricField(
+                    metric_mri=SessionMRI.UNHANDLED_USER.value, alias="users_unhandled", op=None
+                ),
                 MetricField(
                     metric_mri=SessionMRI.ERRORED_USER.value, alias="users_errored", op=None
                 ),
@@ -1441,6 +1463,11 @@ def get_project_release_stats(
                     metric_mri=SessionMRI.ABNORMAL.value, alias="sessions_abnormal", op=None
                 ),
                 MetricField(metric_mri=SessionMRI.CRASHED.value, alias="sessions_crashed", op=None),
+                MetricField(
+                    metric_mri=SessionMRI.UNHANDLED.value,
+                    alias="sessions_unhandled",
+                    op=None,
+                ),
                 MetricField(metric_mri=SessionMRI.ERRORED.value, alias="sessions_errored", op=None),
                 MetricField(metric_mri=SessionMRI.HEALTHY.value, alias="sessions_healthy", op=None),
             ]
@@ -1500,6 +1527,7 @@ def get_project_release_stats(
                 f"{stat}": 0,
                 f"{stat}_abnormal": 0,
                 f"{stat}_crashed": 0,
+                f"{stat}_unhandled": 0,
                 f"{stat}_errored": 0,
                 f"{stat}_healthy": 0,
             }

src/sentry/release_health/metrics_sessions_v2.py

@@ -1,7 +1,7 @@
-""" This module offers the same functionality as sessions_v2, but pulls its data
+"""This module offers the same functionality as sessions_v2, but pulls its data
 from the `metrics` dataset instead of `sessions`.
 
-Do not call this module directly. Use the `release_health` service instead. """
+Do not call this module directly. Use the `release_health` service instead."""
 
 import logging
 from abc import ABC, abstractmethod
@@ -73,6 +73,7 @@ class SessionStatus(Enum):
     CRASHED = "crashed"
     ERRORED = "errored"
     HEALTHY = "healthy"
+    UNHANDLED = "unhandled"
 
 
 ALL_STATUSES = frozenset(iter(SessionStatus))
@@ -242,6 +243,7 @@ def _get_metric_fields(
                 self.status_to_metric_field[SessionStatus.ABNORMAL],
                 self.status_to_metric_field[SessionStatus.CRASHED],
                 self.status_to_metric_field[SessionStatus.ERRORED],
+                self.status_to_metric_field[SessionStatus.UNHANDLED],
             ]
         return [self.get_all_field()]
 
@@ -265,6 +267,7 @@ class SumSessionField(CountField):
         SessionStatus.ABNORMAL: MetricField(None, SessionMRI.ABNORMAL.value),
         SessionStatus.CRASHED: MetricField(None, SessionMRI.CRASHED.value),
         SessionStatus.ERRORED: MetricField(None, SessionMRI.ERRORED.value),
+        SessionStatus.UNHANDLED: MetricField(None, SessionMRI.UNHANDLED.value),
         None: MetricField(None, SessionMRI.ALL.value),
     }
 
@@ -298,6 +301,7 @@ def __init__(
         SessionStatus.ABNORMAL: MetricField(None, SessionMRI.ABNORMAL_USER.value),
         SessionStatus.CRASHED: MetricField(None, SessionMRI.CRASHED_USER.value),
         SessionStatus.ERRORED: MetricField(None, SessionMRI.ERRORED_USER.value),
+        SessionStatus.UNHANDLED: MetricField(None, SessionMRI.UNHANDLED_USER.value),
         None: MetricField(None, SessionMRI.ALL_USER.value),
     }
 
@@ -335,6 +339,8 @@ class SimpleForwardingField(Field):
     """
 
     field_name_to_metric_name = {
+        "unhandled_rate(session)": SessionMRI.UNHANDLED_RATE,
+        "unhandled_rate(user)": SessionMRI.UNHANDLED_USER_RATE,
         "crash_rate(session)": SessionMRI.CRASH_RATE,
         "crash_rate(user)": SessionMRI.CRASH_USER_RATE,
         "crash_free_rate(session)": SessionMRI.CRASH_FREE_RATE,
@@ -373,6 +379,8 @@ def _get_metric_fields(
     "p95(session.duration)": DurationField,
     "p99(session.duration)": DurationField,
     "max(session.duration)": DurationField,
+    "unhandled_rate(session)": SimpleForwardingField,
+    "unhandled_rate(user)": SimpleForwardingField,
     "crash_rate(session)": SimpleForwardingField,
     "crash_rate(user)": SimpleForwardingField,
     "crash_free_rate(session)": SimpleForwardingField,

src/sentry/snuba/metrics/naming_layer/mri.py

@@ -72,20 +72,32 @@ class SessionMRI(Enum):
     ERRORED_PREAGGREGATED = "e:sessions/error.preaggr@none"
     ERRORED_SET = "e:sessions/error.unique@none"
     ERRORED_ALL = "e:sessions/all_errored@none"
+    HANDLED = "e:sessions/handled.unique@none"  # all sessions excluding handled and crashed
+    UNHANDLED = "e:sessions/unhandled@none"  # unhandled, does not include crashed
     CRASHED_AND_ABNORMAL = "e:sessions/crashed_abnormal@none"
     CRASHED = "e:sessions/crashed@none"
     CRASH_FREE = "e:sessions/crash_free@none"
     ABNORMAL = "e:sessions/abnormal@none"
+    HANDLED_RATE = "e:sessions/handled_rate@ratio"  # all sessions excluding handled and crashed
+    UNHANDLED_RATE = "e:sessions/unhandled_rate@ratio"  # unhandled, does not include crashed
     CRASH_RATE = "e:sessions/crash_rate@ratio"
-    CRASH_FREE_RATE = "e:sessions/crash_free_rate@ratio"
+    CRASH_FREE_RATE = "e:sessions/crash_free_rate@ratio"  # includes handled and unhandled
     ALL_USER = "e:sessions/user.all@none"
     HEALTHY_USER = "e:sessions/user.healthy@none"
     ERRORED_USER = "e:sessions/user.errored@none"
     ERRORED_USER_ALL = "e:sessions/user.all_errored@none"
+    HANDLED_USER = "e:sessions/user.handled@none"  # all sessions excluding handled and crashed
+    UNHANDLED_USER = "e:sessions/user.unhandled@none"  # unhandled, does not include crashed
     CRASHED_AND_ABNORMAL_USER = "e:sessions/user.crashed_abnormal@none"
     CRASHED_USER = "e:sessions/user.crashed@none"
     CRASH_FREE_USER = "e:sessions/user.crash_free@none"
     ABNORMAL_USER = "e:sessions/user.abnormal@none"
+    HANDLED_USER_RATE = (
+        "e:sessions/user.handled_rate@ratio"  # all sessions excluding handled and crashed
+    )
+    UNHANDLED_USER_RATE = (
+        "e:sessions/user.unhandled_rate@ratio"  # unhandled, does not include crashed
+    )
     CRASH_USER_RATE = "e:sessions/user.crash_rate@ratio"
     CRASH_FREE_USER_RATE = "e:sessions/user.crash_free_rate@ratio"
     ANR_USER = "e:sessions/user.anr@none"