Skip to content

ref: unify icon exports #98563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref: unify icon exports #98563

wants to merge 1 commit into from

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Sep 1, 2025

  • remove explicit displayName setting. This was a left-over from when we had forwardRef. Now, Icons are just regular named functions, so they will have a correct displayName set automatically.
  • replace export { Icon... } with export function Icon..., as this is what we do everywhere else too.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 1, 2025
@TkDodo TkDodo marked this pull request as ready for review September 1, 2025 08:23
@TkDodo TkDodo requested a review from a team as a code owner September 1, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo