feat(prevent): send consent URL when no-consent #98571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
giovanni-guidini
force-pushed
the
gio/prevent-275
branch
from
531b791 to
91cab2c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ticket: prevent-275 There are some assumptions in these changes: 1. The URL for the settings of an org depends on the `sentry_org.slug`. 2. `github_org_name` is not necessarily the same as `sentry_org.slug` 3. Constructing such URL is non-trivial without the base URL for the Sentry instance 4. It's OK to return _any_ of the valid sentry orgs for a prevent-AI request So based on those assumptions these changes include the URL for the org settings such that we can slap that URL in the "no consent given" message - that appears if you request `@sentry review` in a PR without giving the consent. We want this to add a clearer Call To Action in that message, making it more useful
giovanni-guidini
force-pushed
the
gio/prevent-275
branch
from
91cab2c to
27aa7bc
Compare
| for org_integration in org_integrations: | ||
| try: | ||
| org = Organization.objects.get(id=org_integration.organization_id) | ||
| if _can_use_prevent_ai_features(org): | ||
| return {"consent": True} | ||
| # If this is the last org we will return this URL as the consent URL | ||
| consent_url = org.absolute_url("/settings/organization/") |
There was a problem hiding this comment.
Bug: Non-deterministic URL and Inconsistent Return Structure
This function's consent_url is non-deterministic when multiple organizations lack consent, as its value depends on the arbitrary processing order of integrations. Additionally, the return structure is inconsistent, including consent_url only when consent is False, which may cause issues for callers.
rohitvinnakota-codecov
approved these changes
Sep 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
ticket: prevent-275 There are some assumptions in these changes: 1. The URL for the settings of an org depends on the `sentry_org.slug`. 2. `github_org_name` is not necessarily the same as `sentry_org.slug` 3. Constructing such URL is non-trivial without the base URL for the Sentry instance 4. It's OK to return _any_ of the valid sentry orgs for a prevent-AI request So based on those assumptions these changes include the URL for the org settings such that we can slap that URL in the "no consent given" message - that appears if you request `@sentry review` in a PR without giving the consent. We want this to add a clearer Call To Action in that message, making it more useful **Note:** Point 4 in particular means that we might want to limit the `consent_url` return to cases where there's exactly 1 org found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: prevent-275
There are some assumptions in these changes:
sentry_org.slug.github_org_nameis not necessarily the same assentry_org.slugSo based on those assumptions these changes include the URL for the org settings such that we can slap that URL in the "no consent given" message - that appears if you request
@sentry reviewin a PR without giving the consent. We want this to add a clearer Call To Action in that message, making it more usefulNote: Point 4 in particular means that we might want to limit the
consent_urlreturn to cases where there's exactly 1 org found.