Fix seer api auth header for delete by hash #98974
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "No auth header found" errors for Seer grouping record deletion by ensuring all Seer API calls are properly authenticated.
Why these changes?
Previously,
call_seer_to_delete_these_hashes
andcall_seer_to_delete_project_grouping_records
were making directurlopen
calls to Seer without the required authentication headers, leading to 401 errors.What was changed?
call_seer_to_delete_these_hashes
: Switched from directurlopen
tomake_signed_seer_api_request
for authenticated POST requests.call_seer_to_delete_project_grouping_records
: Converted the unauthenticated GET request to an authenticated POST request, aligning with other Seer API patterns and addressing a previous TODO.make_signed_seer_api_request
and added new comprehensive tests forcall_seer_to_delete_project_grouping_records
.This ensures all Seer deletion requests are signed and properly authenticated.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.