Fix missing seer api auth header #98977
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jenn <[email protected]>
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #98977 +/- ##
==========================================
+ Coverage 74.26% 81.23% +6.97%
==========================================
Files 8536 8538 +2
Lines 377318 377151 -167
Branches 23956 23956
==========================================
+ Hits 280203 306373 +26170
+ Misses 96749 70412 -26337
Partials 366 366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
SEER_API_SHARED_SECRETwas hardcoded to an empty string, preventing the generation ofRpcsignatureauthentication headers for Seer API requests.This PR:
SEER_API_SHARED_SECRETto load its value from theSEER_API_SHARED_SECRETenvironment variable.SEER_API_SHARED_SECRETwhen running in development mode (SILO_DEVSERVERorIS_DEV) if the environment variable is not set.This ensures that requests to the Seer API are properly signed, resolving "No auth header found" errors in both production and development environments.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.