chore(lint): bump stylelint to 17 without rewriting published CSS - #24
Merged
Conversation
stylelint 16 → 17 and stylelint-config-standard-scss 14 → 17, clearing the peer mismatch the config had against stylelint 16. The pin at ^14 existed because from ^15 the preset enables color-function-alias-notation, which rewrites rgba() to rgb() in the CSS we publish (128 occurrences across 11 of the 26 components). The rule is therefore switched off, next to color-function-notation which was already off — this config already disables that rule and alpha-value-notation, the same family for the same reason. Verified: zero CSS files changed, stylelint and the full suite pass. No release: devDependencies and lint config only.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughStylelint and its standard SCSS configuration are upgraded to major version 17. The Stylelint configuration is reformatted, disables ChangesStylelint update
Estimated code review effort: 2 (Simple) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stylelint16 → 17 andstylelint-config-standard-scss14 → 17, propagated frommantine-base-component. Also clears the peer mismatch the config had against stylelint 16.Why the rule is disabled instead of the CSS being fixed
From config
^15the preset enablescolor-function-alias-notation, which rewritesrgba()→rgb()in the CSS we publish — 128 occurrences across 11 of the 26 components.The rule is switched off next to
color-function-notation, which was already off. Not an ad-hoc exception: this config already disables bothcolor-function-notationandalpha-value-notation, the same family for the same reason. The project had already decided not to have its colour syntax rewritten.Measured on
mantine-ledandmantine-marquee(worst case, 72 occurrences) before the rollout: 100% of what stylelint 17 reports is that single rule, so nothing else needed relaxing.Test plan
.stylelintrc.json,package.json,yarn.lockNo release: devDependencies and lint config only.
Summary by CodeRabbit