Conversation
Member
|
Oh nice, I've had implementing something like this in the back of my mind for ages now |
cwfitzgerald
previously approved these changes
Sep 14, 2026
cwfitzgerald
left a comment
Member
There was a problem hiding this comment.
Sorry I'm just testing something I haven't actually looked at this yet
|
Tick the box to add this pull request to the merge queue (same as
|
inner-daemons
self-requested a review
September 16, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #6673
Description
Instead of recording a barrier for the staging buffer immediately when Queue::write_buffer/texture is called, defer it to submit time, so that only a single barrier is needed for N writes.
This only works for the first time you write to a resource (I think per submit?), with subsequent writes reverting back to immediate barriers (23a82b5).
Subresource ranges are also not tracked, barriers are still per-resource.
Testing
TODO
Squash or Rebase?
Squash
Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.wgpumay be affected behaviorally.