[naga spv-out] Add f16 io polyfill #7884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+44
to
+48
| pub fn register_variable(&mut self, variable_id: Word, f32_type_id: Word, f16_type_id: Word) { | ||
| self.variable_map | ||
| .insert(variable_id, (f32_type_id, f16_type_id)); | ||
| } |
There was a problem hiding this comment.
question: I noticed that f16_type_id is never used when recalled via get_polyfill_info. Is this a bug, or just some data that can be eliminated?
| converted, | ||
| &mut prelude.body, | ||
| ); | ||
| id = converted; |
There was a problem hiding this comment.
question: You have an id = converted; statement here, but not in the other branch where we handle a Struct case as fallback. Should that be there, too?
ErichDonGubler
force-pushed
the
fix_shader16_vulkan
branch
from
44c88df to
ca906b2
Compare
ErichDonGubler
added
type: enhancement
ErichDonGubler
force-pushed
the
fix_shader16_vulkan
branch
from
ca906b2 to
a8cddd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Extension of #7656
Description
Polyfills f16 I/O when storageInputOutput16 capability is missing on vulkan backend.
Emits these variables as f32 and inserts OpFConverts at loads/stores.
If capability is available, generated spirv is unaffected.
Testing
Added a snapshot test and some basic inspection of the spirv disassembly in spirv_capabilities.rs.
Generated spirv in snapshots look okay to me, but I haven't yet run any live correctness tests.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.