Skip to content

Add support for miri to the codebase #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jul 13, 2025

Wires in support for miri (and potentially ASAN) in the codebase.

Main transform was manually enumerating tests.

@cwfitzgerald cwfitzgerald marked this pull request as ready for review July 18, 2025 03:58
@cwfitzgerald cwfitzgerald requested a review from a team as a code owner July 18, 2025 03:58
Copy link
Contributor

@andyleiserson andyleiserson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice to have, thank you!

It is too bad to lose the implicit test enumeration, especially because the macro suppresses the dead code warning if you forget to add a test to the list. But I think we can land this change and worry about improvements later.

I played with a macro a bit and came up with this, but it doesn't handle the wasm case (or run_sync, but that shouldn't be hard).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a commented test in this file, it might be worth putting a reminder by the commented test that it needs to be added to the test list if restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants