Skip to content

Allow copying one layer of depth/stencil textures#8020

Merged
andyleiserson merged 3 commits intogfx-rs:trunkfrom
andyleiserson:layer-copy
Jul 29, 2025
Merged

Allow copying one layer of depth/stencil textures#8020
andyleiserson merged 3 commits intogfx-rs:trunkfrom
andyleiserson:layer-copy

Conversation

@andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Jul 29, 2025

This fixes a regression introduced by #7935.

Multisampled and depth/stencil textures require copying an entire surface, but should not require copying all layers.

Testing
Enables the CTS test that caught the regression in Firefox.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson requested review from a team and crowlKats as code owners July 29, 2025 03:14
@andyleiserson
Copy link
Contributor Author

andyleiserson commented Jul 29, 2025

Looks like these tests are still failing on Vulkan and Windows. I confirmed that the Vulkan failures existed prior to #7935, but I don't immediately know about Windows.

Edit: and it looks like they're marked as passing on all platforms in Firefox, so something doesn't make sense here.

@teoxoy
Copy link
Member

teoxoy commented Jul 29, 2025

This looks reasonable to me though we should mention "array layer" instead of "mip level" since that's what the depth_or_array_layers represents for these textures.

It is odd that the tests are not passing on Windows - but it could be that it's only reproducible on WARP and not the GPUs we have in Mozilla's CI.

@andyleiserson andyleiserson merged commit 5089063 into gfx-rs:trunk Jul 29, 2025
40 checks passed
@andyleiserson andyleiserson deleted the layer-copy branch July 29, 2025 17:18
@andyleiserson andyleiserson changed the title Allow copying one mip level of depth/stencil textures Allow copying one layer of depth/stencil textures Jul 29, 2025
@andyleiserson
Copy link
Contributor Author

On both Vulkan and dx12, the tests actually pass if run separately rather than in combination. I filed #8021 for this and put them in the list separately for now.

andyleiserson added a commit to andyleiserson/wgpu that referenced this pull request Jul 30, 2025
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants