Skip to content

Vendor web sys #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Vendor web sys #8070

merged 2 commits into from
Aug 8, 2025

Conversation

andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Aug 8, 2025

The only thing that has changed in the parts of web-sys we use is that the github URLs for wasm-bindgen are updated. But this memorializes the bindings as generated from the authoritative copy of the web-sys repo, and not my fork, now that wasm-bindgen/wasm-bindgen#4508 is merged.

Review note: I made some changes to the implementation of the vendor-web-sys xtask, these are in a separate commit, or just scroll to the very bottom of the diff view. Everything else is from vendoring.

Testing
Tested operation of the vendor-web-sys command locally. Other than that, will let CI do its thing.

Squash or Rebase? Rebase (but please squash fixups first, if any)

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson requested a review from a team as a code owner August 8, 2025 19:50
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D0pe

@cwfitzgerald cwfitzgerald merged commit 605f40d into gfx-rs:trunk Aug 8, 2025
40 checks passed
@andyleiserson andyleiserson deleted the vendor-web-sys branch August 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants