Skip to content

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Aug 14, 2025

Connections
Addresses #8089
Obseleted by #7834

Description
Previously, support for HLSL/DXIL passthrough wasn't actually exposed. This is a one-liner to fix that.

Testing
No testing unfortunately, but hopefully @jonahnm can verify this works

Squash or Rebase?
Squash probably cus commit is named dumb

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@SupaMaggie70Incorporated SupaMaggie70Incorporated requested a review from a team as a code owner August 14, 2025 06:23
@SupaMaggie70Incorporated SupaMaggie70Incorporated changed the title Make DX12 backend actually expose Make DX12 backend actually expose DXIL/HLSL passthrough feature Aug 14, 2025
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an amazingly tricky change to review 😂

Whoops!

@cwfitzgerald cwfitzgerald merged commit 0c0df24 into gfx-rs:trunk Aug 14, 2025
40 checks passed
@SupaMaggie70Incorporated SupaMaggie70Incorporated deleted the dx12-passthrough-feature-fix branch August 14, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants