-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add more complete MSL passthrough #8140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more complete MSL passthrough #8140
Conversation
Would be nice to get some tests in for this eventually. |
Probably covered by #8128 |
@SupaMaggie70Incorporated @cwfitzgerald The commit message on 24a31c4 ("Only commit hopefully") is really not helpful. It's good that it links to the PR, but if we're going to try to help other developers, we need to give them just a brief summary of what the change is about. |
@jimblandy oh that's weird, I expected it to have the squashed commit name be the PR title, which is why I wasn't worried about. This is the first PR I merged on my phone in a while, I wonder if the mobile app does something weird.... |
The PR says this
In the future I'll try to actually assign meaningful names to commits though |
Okay, I see. Yes, even just the PR summary would be better. We now have two commits in the recent history with this same message. |
The previous commit having that name is why I added this to the summary XD |
Connections
Related to #8139
Description
Previously, the
load_shader
function on metal backend would panic withpanic!("load_shader required a naga shader");
if you tried to create a non-compute pipeline with a passthrough shader. This is a quick fix to address thatTesting
Already exists
Squash or Rebase?
Only commit is named "only commit hopefully" so probably squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.