-
Couldn't load subscription status.
- Fork 1.1k
An even fancier CHANGELOG check in CI
#8416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
An even fancier CHANGELOG check in CI
#8416
Conversation
949518d to
c34aab1
Compare
5ec93a2 to
6a6742d
Compare
adaa7a4 to
372d81d
Compare
|
I've validated that adding the escape hatch label works (CI run link), with the following experience screenshot:
|
574764d to
e30c999
Compare
e30c999 to
fcd7db1
Compare
…xtask changelog` TODO: Lines seem off in output. WTF? TODO: fix tests
… hatch for `--warn-only`
fcd7db1 to
0b520df
Compare
| `<to_commit>` is the tip of the `git diff` that will be used for checking (1). | ||
| --emit-github-messages Emit GitHub workflow commands for nice integrations like error reporting in PR views. | ||
| --warn-only Only reports issues as warnings, rather than reporting errors and forcing a non-zero exit code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: We might add other checks. Let's make this name more specific, i.e., --allow-released-changes.


Builds further on #8351 by integrating our
CHANGELOGcheck more deeply into GitHub:CHANGELOGissues, so they show up in diff views for the PR. By default, this is anerrormessage.changelog: released entry changedlabel is applied to the PR, the check is run with the--warn-onlyflag, which emitswarnings instead oferrors, and emits error code 0. The check triggers on label changes, so no push is needed to apply this escape hatch.