Move Features::PRIMITIVE_INDEX into the WebGPU group #9101
Move Features::PRIMITIVE_INDEX into the WebGPU group #9101andyleiserson merged 1 commit intogfx-rs:trunkfrom
Features::PRIMITIVE_INDEX into the WebGPU group #9101Conversation
|
I've marked this as draft because the CTS failures in CI appear real, and I don't have time to debug them right now. #9105 is a failure related to |
fe52ea9 to
b7e8d43
Compare
9e64b40 to
0326f58
Compare
0326f58 to
b65912e
Compare
|
@andyleiserson If there are bugs on FXC, should we not expose the feature on FXC? |
My inclination is that it's not worth the trouble (we don't know whether it's a wgpu bug or an FXC bug, and we don't know what the impact of the bug is), that we can just leave it until there is a complaint. But I don't feel strongly about that -- Firefox cares mostly about DXC. I guess another option would be to note in the changelog that there may be issues on FXC. |
|
I'm mainly worried that if this is a wgpu bug then it could still cause problems when using DXC, but I have no idea. I haven't looked at what shaders are involved in the tests. |
b65912e to
9a595b1
Compare
|
Changes look good, I reopened #9105 as it's marked as an FXC issue. If people want to investigate fixing it. |
Enable relevant CTS tests.
9a595b1 to
0e6d964
Compare
Will conflict with #9119 and #9163.
Renames
Features::SHADER_PRIMITIVE_INDEXtoFeatures::PRIMITIVE_INDEX(for consistency with the spec, which usesshader_f16but notshader_primitive_index), and moves it to the WebGPU feature set.Putting it in the WebGPU feature set results in it being exposed by Deno and available in CTS runs, so, enable the CTS tests for
primitive_index. I've also added acts_runnerintegration test that checks the feature is exposed, because the CTS silently skips the relevant tests if it is not.I've also reworded the changelog entry related to
enable primitive_index, but the actual functional change was in #8879.CC @inner-daemons
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.