Skip to content

Conversation

Cito
Copy link
Member

@Cito Cito commented Jul 16, 2025

Adds endpoints that allow fetching and revoking actual access grants independently of any access requests.

These endpoints essentially function as proxies to the corresponding endpoints of the claims repository, but they have added authorization and augment the access grants with information on the associated datasets.

@coveralls
Copy link

coveralls commented Jul 16, 2025

Pull Request Test Coverage Report for Build 16367870741

Details

  • 166 of 183 (90.71%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 88.425%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ars/ports/inbound/repository.py 30 32 93.75%
src/ars/ports/outbound/access_grants.py 6 8 75.0%
src/ars/adapters/inbound/fastapi_/routes.py 21 26 80.77%
src/ars/core/repository.py 45 53 84.91%
Files with Coverage Reduction New Missed Lines %
src/ars/ports/outbound/access_grants.py 1 82.35%
Totals Coverage Status
Change from base Build 15969458802: 0.5%
Covered Lines: 657
Relevant Lines: 743

💛 - Coveralls

@Cito Cito marked this pull request as ready for review July 16, 2025 21:51
@Cito Cito requested a review from TheByronHimes July 17, 2025 07:00
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things to address before approving

@Cito Cito requested a review from TheByronHimes July 18, 2025 10:06
@Cito Cito merged commit 83d860f into main Jul 18, 2025
9 checks passed
@Cito Cito deleted the feature/access-management-endpoints-gsi1732 branch July 18, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants