core/gtk: use command line supplied by the shell in notifications #9134
+583
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
requested changes
Oct 11, 2025
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Couple comments. Still working my way through it.
jcollie
force-pushed
the
command-finished-notification-with-cmdline
branch
from
2c7dd8b to
1d511d6
Compare
jcollie
force-pushed
the
command-finished-notification-with-cmdline
branch
2 times, most recently
from
26ed220 to
3a25710
Compare
jcollie
force-pushed
the
command-finished-notification-with-cmdline
branch
2 times, most recently
from
0c9599a to
91f41c6
Compare
jcollie
force-pushed
the
command-finished-notification-with-cmdline
branch
6 times, most recently
from
e2293cc to
0876df6
Compare
Some shells use OSC 133;C to tell us what command is being executed. Use that information to enhance our notifications that a command has finished.
jcollie
force-pushed
the
command-finished-notification-with-cmdline
branch
from
0876df6 to
2e121d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some shells use OSC 133;C to tell us what command is being executed. Use that information to enhance our notifications that a command has finished.