Release 3.0.0 - allow for omniauth 2.0 series

CHANGELOG.md

@@ -1,3 +1,11 @@
+## v3.0.0
+
+* Allow for OmniAuth 2.0 series. (#16)
+
+## v2.5.1
+
+* Add dependency constraint for omniauth 1.x (#16)
+
 ## v2.5.0
 
 * Added Slack v2 API support (oauth flow, scopes, tokens).

lib/omniauth-slack/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Slack
-    VERSION = "2.5.0"
+    VERSION = "3.0.0"
   end
 end

lib/omniauth/strategies/slack.rb

@@ -196,7 +196,7 @@ def client
       # some errors in call to /api/oauth.[v2.]access.
       #
       def callback_url
-        options.redirect_uri || full_host + script_name + callback_path
+        options.redirect_uri || full_host + callback_path
       end
 
       ### Possibly obsolete

omniauth-slack.gemspec

@@ -16,7 +16,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'omniauth-oauth2', '>= 1.4.0'
+  spec.add_runtime_dependency 'omniauth', '~> 2.0'
+  spec.add_runtime_dependency 'omniauth-oauth2', '~> 1.7.1'
 
   spec.add_development_dependency 'bundler', '>= 1.11.2'
   spec.add_development_dependency 'rake'

test/strategy_test.rb

@@ -94,6 +94,13 @@ class CallbackUrlTest < StrategyTestCase
     strategy.stubs(:script_name).returns("") # as not to depend on Rack env
     assert_equal "#{url_base}/auth/slack/done", strategy.callback_url
   end
+
+  test "returns callback_url when setting script_name" do
+    url_base = "http://auth.request.com"
+    @request.stubs(:url).returns("#{url_base}/page/path")
+    strategy.stubs(:script_name).returns("/foo") # as not to depend on Rack env
+    assert_equal "#{url_base}/foo/auth/slack/callback", strategy.callback_url
+  end
 end
 
 class UidTest < StrategyTestCase