Add explicit permissions to GitHub Actions workflows#78
Merged
Conversation
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add explicit permissions to workflow files
Add explicit permissions to GitHub Actions workflows
Nov 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by adding explicit permission declarations to GitHub Actions workflows, implementing the principle of least privilege. Previously, both workflows relied on default permissions, which could grant unnecessary access.
- Added
permissions: contents: readto thebuildjob innodejs.yml - Added
permissions: contents: readto thepublish-npmjob inpublish.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/nodejs.yml |
Added minimal contents: read permission to build job for code checkout |
.github/workflows/publish.yml |
Added minimal contents: read permission to publish job for code checkout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuliu-dev
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow files lacked explicit permission declarations, relying on default permissions which violate least-privilege security principles.
Changes
.github/workflows/nodejs.yml: Addedpermissions: contents: readto thebuildjob.github/workflows/publish.yml: Addedpermissions: contents: readto thepublish-npmjobBoth workflows only perform checkouts and execute local build/test commands. The
publish.ymlworkflow uses an NPM token for publishing, which doesn't require additional GitHub permissions.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.googleapis.comnode install.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.