fix: correct double-bump in Version Packages PR title - #61
Merged
Conversation
The versionPr.create() hook ran bumpVersion() on the graph package, but create() fires AFTER the draft is applied — the graph already holds the bumped version, so bumpVersion bumped it a second time (title said v0.21.0 while the PR bumped to v0.20.0). Read the applied version directly from the graph instead. Reproduced in memory: graph .version = 0.20.0 (correct), bumpVersion(pkg) = 0.21.0 (bug).
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format No changelogs yetThis PR has no pending changelog files. If your changes require a release, add a changelog before merging. Run Managed by Tegami. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
versionPr.create()hook added in #60 titled the Version Packages PRchore: release v0.21.0while the PR actually bumped to v0.20.0.Cause
create()runs after the draft is applied (the github plugin'sapplyCliDraft), sothis.graphalready holds the bumped version. Callingdraft.getPackageDraft(...).bumpVersion(pkg)then applied the minor bump a second time: 0.20.0 → 0.21.0. My original validation missed it because it ran against the unapplied draft (graph still at 0.19.0 → 0.20.0).Fix
Read the already-applied version straight off the graph — no re-bump:
Reproduced in-memory against a probe changelog:
.version→0.20.0(correct),bumpVersion(pkg)→0.21.0(the bug).Note: the already-merged #59 keeps its wrong title (cosmetic; it bumped 0.20.0 correctly). This prevents it on future releases.