fix: register atma font bundle in tsdown build entries - #69
Merged
Conversation
The renderer's tsdown config hardcodes each font bundle as a build entry and in the .ttf copy list, so a new bundle isn't picked up by `bun --filter tegaki build` unless it's added there too — CI's deploy-docs build failed resolving `tegaki/fonts/atma` because dist/ never got the atma output.
Owner
|
Thank you. I was going to apply the same fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #67. The renderer's
tsdown.config.tshardcodes each bundled font as a build entry (and in the.ttfcopy list inwriteBundle), so a new font bundle isn't picked up bybun --filter tegaki buildunless it's added there too. The Atma bundle from #67 was missing from both lists, sodist/fonts/atmawas never generated — this broke the docs site build (Rolldown failed to resolve import "tegaki/fonts/atma"inHomePageExamples.tsx), which is why the last twoDeploy Docs to GitHub Pagesruns failed.'fonts/atma/bundle': 'fonts/atma/bundle.ts'to theentrymap'atma'to the.ttfcopy list inwriteBundle()Test plan
rm -rf packages/renderer/dist packages/website/dist && bun --filter tegaki buildnow emitsdist/fonts/atma/*cd packages/website && bun run buildsucceeds (previously failed resolvingtegaki/fonts/atma)bun checkspasses