fix device inactivity handling, improve styling, and add play from queue feature. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of device inactivity wasn’t implemented properly earlier. When the device is inactive, the request:
{{ $currentlyPlaying := newRequest "https://api.spotify.com/v1/me/player"
| withHeader "Authorization" (print "Bearer " $accessToken)
| getResponse
}}
returns an empty response with a 204 status code.
To address this, I’ve added a new check for this specific condition. Previously, since this case wasn’t accounted for, the widget would display nothing whenever the device was inactive.
- Added margins and padding to the div containers with class `widget-content-frame` - Enabled frame and title. - Changed the Now Playing and Upcoming titles form h1 to h5.
joelmathewthomas
changed the title
|
Looks good. Thanks for the updates!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a set of improvements and fixes for the Spotify Player widget:
Bugfix
Improvements
Refined styling of .widget-content-frame elements:
Added padding and margins
Enabled frame and title display
Adjusted heading levels for better layout consistency
Centered the Play/Pause buttons
New Feature
Other
Screenshots
feature.mp4