Skip to content

pre-commit.ci: update pre-commit hooks #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

pre-commit.ci: update pre-commit hooks #628

merged 3 commits into from
Oct 15, 2025

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jul 7, 2025 •
edited
Loading

Saransh-cpp
Saransh-cpp reviewed Jul 8, 2025
View reviewed changes
paddyroddy
paddyroddy reviewed Jul 8, 2025
View reviewed changes
glass/fields.py
Comment on lines 1073 to 1080
cov_method: Callable[..., NDArray[Any]]
if method == "clip":
from glass.algorithm import cov_clip as cov_method
from glass.algorithm import cov_clip as cov_method # noqa: PLC0415
elif method == "nearest":
from glass.algorithm import cov_nearest as cov_method
from glass.algorithm import cov_nearest as cov_method # noqa: PLC0415
else:
msg = f"unknown method '{method}'" # type: ignore[unreachable]
raise ValueError(msg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a re-write

@ntessore
Copy link
Collaborator

ntessore commented Jul 8, 2025

Let's disable PLC0415 because there are clearly benefits to importing outside top-level for slow imports. I can do that here or in a separate PR.

@paddyroddy
Copy link
Member

Let's disable PLC0415 because there are clearly benefits to importing outside top-level for slow imports. I can do that here or in a separate PR.

I'll do it

@Saransh-cpp
Copy link
Member

Raised #629 for the failing tests 😞

paddyroddy
paddyroddy reviewed Jul 8, 2025
View reviewed changes
.pre-commit-config.yaml
rev: v0.11.12
rev: v0.12.2
hooks:
- id: ruff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated

paddyroddy
paddyroddy reviewed Jul 8, 2025
View reviewed changes
pyproject.toml Outdated
[tool.ruff]
fix = true
force-exclude = true
per-file-target-version = {"examples/*" = "py313"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this new setting in the blog https://astral.sh/blog/ruff-v0.12.0#version-related-syntax-errors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really useful! Good spot!

@paddyroddy paddyroddy self-assigned this Jul 8, 2025
ntessore
ntessore requested changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@ntessore ntessore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should undo the changes around PLC0415, since we switched that one off. (I'm happy to do that, since you are off, just give me a 🚀.)

@paddyroddy
Copy link
Member

We should undo the changes around PLC0415, since we switched that one off. (I'm happy to do that, since you are off, just give me a 🚀.)

I turned it off for tests, not the main code — hesitant to do so. Besides the fitsio import, do we really want the others to stay as they are?

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 77aa0ec to 0856279 Compare August 4, 2025 19:55
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 0856279 to 6d38e6c Compare September 1, 2025 19:45
@pre-commit-ci
pre-commit.ci: update pre-commit hooks
4264e4c 
updates:
- [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
- [github.com/astral-sh/ruff-pre-commit: v0.11.12 → v0.13.3](astral-sh/ruff-pre-commit@v0.11.12...v0.13.3)
- [github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0](adamchainz/blacken-docs@1.19.1...1.20.0)
- [github.com/pappasam/toml-sort: v0.24.2 → v0.24.3](pappasam/toml-sort@v0.24.2...v0.24.3)
- [github.com/rbubley/mirrors-prettier: v3.5.3 → v3.6.2](rbubley/mirrors-prettier@v3.5.3...v3.6.2)
- [github.com/pre-commit/mirrors-mypy: v1.16.0 → v1.18.2](pre-commit/mirrors-mypy@v1.16.0...v1.18.2)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6d38e6c to 4264e4c Compare October 6, 2025 20:40
@ntessore
Copy link
Collaborator

@paddyroddy @connoraird It's been a while, and ruff v6 is pretty nifty, so can we merge this one?

@ntessore ntessore added the run-examples Run the example notebooks label Oct 14, 2025
@paddyroddy
Copy link
Member

@paddyroddy @connoraird It's been a while, and ruff v6 is pretty nifty, so can we merge this one?

Yes, let's get it in. Do you mean v6?

@paddyroddy paddyroddy merged commit f835b42 into main Oct 15, 2025
13 of 14 checks passed
@paddyroddy paddyroddy deleted the pre-commit-ci-update-config branch October 15, 2025 07:18
@paddyroddy paddyroddy mentioned this pull request Oct 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paddyroddy paddyroddy paddyroddy left review comments

@ntessore ntessore ntessore approved these changes

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

Assignees

@paddyroddy paddyroddy

Labels

run-examples Run the example notebooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntessore @paddyroddy @Saransh-cpp