feat: add empty module validation #4794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this test-wasm CI error, but checking for passed PRs like #4791 I think it may be something related to my changes so I will check it |
|
BTW, a good thing would be to add some files like CHANGELOG.md to not trigger all CI checks. All CI tasks are running again because I changed the CHANGELOG.md |
|
By checking this PR, I think I should add my changes to Unreleased? |
vitorsouzaalmeida
force-pushed
the
feat/empty-module-validation
branch
from
41e93ec to
45590fc
Compare
Yeah! |
|
Hey @giacomocavalieri |
lpil
reviewed
Jul 22, 2025
...ge-compiler/src/snapshots/test_package_compiler__generated_tests__erlang_app_generation.snap
Outdated
Show resolved
Hide resolved
test-package-compiler/cases/empty_module_publish_validation/gleam.toml
Outdated
Show resolved
Hide resolved
|
I've just updated the code @lpil |
lpil
reviewed
Aug 29, 2025
|
Thank you guys by reviewing it again. I will back on it between today and tomorrow |
Prevent publishing packages with empty modules and emit warnings during compilation when modules contain no public definitions.
Moved from AST checking to module interface, similar to what I did on publish.rs. Also, previously the code counted public definitions from the AST and checked if the definitions list was empty. Now it directly checks if both the values and types HashMaps in the module interface are empty, as suggested by @GearsDatapacks
vitorsouzaalmeida
force-pushed
the
feat/empty-module-validation
branch
from
4d6d163 to
db68575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4093
Prevent publishing packages with empty modules and emit warnings during compilation when modules contain no public definitions.