Fix bug when inlining shadowed variables #4892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Aug 29, 2025
GearsDatapacks
force-pushed
the
fix-inlining-shadowed-variables
branch
from
e8dc51d to
4e06382
Compare
|
Ok, I've made it work for |
lpil
reviewed
Sep 7, 2025
GearsDatapacks
force-pushed
the
fix-inlining-shadowed-variables
branch
2 times, most recently
from
eae2bba to
2f5c66f
Compare
GearsDatapacks
force-pushed
the
fix-inlining-shadowed-variables
branch
from
2f5c66f to
bb0854a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4877
As noted in the comments of one of the functions, ideally we would merge this deduplication logic with that done in the code generators, however for now we need to ensure we don't have critical bugs such as this, so that larger item of work can wait until later.