Make sure the compiler always rejects duplicate modules#5367
Open
giacomocavalieri wants to merge 2 commits intogleam-lang:mainfrom
Open
Make sure the compiler always rejects duplicate modules#5367giacomocavalieri wants to merge 2 commits intogleam-lang:mainfrom
giacomocavalieri wants to merge 2 commits intogleam-lang:mainfrom
Conversation
lpil
reviewed
Feb 13, 2026
giacomocavalieri
force-pushed
the
fix-5352
branch
from
55e1209 to
64c0995
Compare
giacomocavalieri
force-pushed
the
fix-5352
branch
from
64c0995 to
e32d03b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #5352
Now the compiler should always detect when a dependency is defining a module with the same name as the root project, or even when two imported dependencies are defining a module with the same name.