Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a
tls_versionsconfiguration option that allows callers to restrict which TLS protocol versions are used.We encountered the need for this option after discovering many BMCs (Baseboard Management Controllers) at our organization that have buggy TLS 1.3 implementations that fail the middlebox compatibility handshake. The workaround, that we've been using with the Hackney client till now, is to force TLS 1.2 for these connections. So we thought we'd add the same support to httpc.
We test by connecting to check.ja3.zone, which echoes back the negotiated TLS version in its JSON response.