Add a11y attr option for hidden/visible slides #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable a default option that will set a visible class to all elements in the current view and set aria-hidden on slides that are not in view. This will also apply a negative tab index for all focusable elements for slides that are not currently in the view.
|
Is there something stopping this from being merged? It seems like a great addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable a default option that will set a visible class to all elements in the current view and set aria-hidden on slides that are not in view. This will also apply a negative tab index for all focusable elements for slides that are not currently in view.
The main purpose of this is to prevent screen reader users and keyboard users from focusing content that is off-screen and be able to dynamically apply classes to elements that are in view given the option
perView.