fix tinymce overflow auto-hide#23418
Open
cconard96 wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Open
fix tinymce overflow auto-hide#23418cconard96 wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
cconard96 wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Conversation
Rom1-B
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
fixes #23417
The previous auto-hide fix was not restrictive enough.
Since TinyMCE editors are being loaded even before something is being edited, the editor has the chance to make a button active depending on the content. If a note has a link and the cursor position would be on that link, the link button would be "active". The auto-hide logic would then click this button which would bring up the Insert/Edit link modal any time the user clicked anywhere on the page.
This fix restricts the logic to only work on the "overflow-button" instead of any active button.