Fix(plugin): deduplicate plugin directories list#23468
Draft
Mary-Clb wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Draft
Fix(plugin): deduplicate plugin directories list#23468Mary-Clb wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Mary-Clb wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Conversation
Rom1-B
reviewed
Mar 13, 2026
| protected static function getPluginDirectories(): array | ||
| { | ||
| return GLPI_PLUGINS_DIRECTORIES; | ||
| return array_values(array_unique(GLPI_PLUGINS_DIRECTORIES)); |
Contributor
There was a problem hiding this comment.
There are several places where GLPI_PLUGINS_DIRECTORIES is called directly without going through this function.
Contributor
There was a problem hiding this comment.
It sounds strange there are duplicates in this kind of constant definition. If issue is confirmed; it probably must be fixed at the declaration.
Contributor
There was a problem hiding this comment.
By default, we have:
'GLPI_MARKETPLACE_DIR' => $this->root_dir . '/marketplace',
'GLPI_PLUGINS_DIRECTORIES' => [
'{GLPI_MARKETPLACE_DIR}',
$this->root_dir . '/plugins',
],
However, if in locale_define.php it is written:
define('GLPI_MARKETPLACE_DIR', GLPI_ROOT . '/plugins');
GLPI_PLUGINS_DIRECTORIES has the same value twice.
Contributor
There was a problem hiding this comment.
In this case the local_define is bad.
But anyway; rather than trying to dedup everywhere the constant is used, the fix must be done at its instanciation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description