Drop unused legacy addVisibilityRestrict methods#23473
Open
trasher wants to merge 1 commit intoglpi-project:mainfrom
Open
Drop unused legacy addVisibilityRestrict methods#23473trasher wants to merge 1 commit intoglpi-project:mainfrom
trasher wants to merge 1 commit intoglpi-project:mainfrom
Conversation
Those methods should have been removed since v11.0; no idea why they've been kept
Contributor
|
I'm guessing this was my fault. GLPI was still going to be v10.1 when I started rewriting the search code so I had to avoid breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those methods should have been removed since v11.0; no idea why they've been kept
If necessary, they could be marked a deprecated for v11; but we should really not have to deal with those in v12.