show approvals in read-only mode when Object Lock is enabled - #23477
show approvals in read-only mode when Object Lock is enabled#23477f2cmb wants to merge 4 commits into
Conversation
|
Manual backoffice testing confirmed the fix across 5 scenarios :
This validates that the READ right addition resolves the original issue where approvals were hidden in read-only contexts, while preserving proper access control for unprivileged profiles. |
| // making it impossible to view validations in read-only contexts (e.g. Object Lock mode). | ||
| foreach (['ticketvalidation', 'changevalidation'] as $right_name) { | ||
| $DB->update( | ||
| 'glpi_profilerights', |
There was a problem hiding this comment.
Usually, we do not change existing "configuration" on update. There is no reliable way to know if it's not been changed, or set on purpose.
There was a problem hiding this comment.
This change is too important for a bugfixes version. Maybe it could be valid for the main branch, but before doing rights management changes, you should validate that @orthagh is OK with this.
AdrienClairembault
left a comment
AdrienClairembault
left a comment
There was a problem hiding this comment.
Waiting for cedric's comment to be addressed.
|
Since this topic is not a priority, I close the PR. |
|
This PR has been is closed and has been automatically locked. Please open a new issue with all requested information for related bugs. |
4 participants
Description
Ticket/Change approvals were hidden when viewing items in read-only mode (Object Lock enabled) because
CommonITILValidation::canView()required write-level rights (CREATE/VALIDATE/PURGE) which get stripped by the lock profile.Adds READ to the validation rights model so viewing approvals no longer requires write permissions.