Skip to content

Fix: use unsigned value to represent bytes #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Fix: use unsigned value to represent bytes #4493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa78994
[1/2]Fixes char to unsigned char for byte representation
ThalesBarretto Mar 9, 2025
4879264
[2/2]Fixes char to unsigned char for byte representation
ThalesBarretto Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xlators/cluster/afr/src/afr-inode-write.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ afr_arbiter_writev_wind(call_frame_t *frame, xlator_t *this, int subvol)
{
afr_local_t *local = frame->local;
afr_private_t *priv = this->private;
static char byte = 0xFF;
static unsigned char byte = 0xFF;
static struct iovec vector = {&byte, 1};
int32_t count = 1;

Expand Down
4 changes: 2 additions & 2 deletions xlators/features/compress/src/cdc-helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
* gzip_header is added only during debugging.
* Refer to the function cdc_dump_iovec_to_disk
*/
static const char gzip_header[10] = {'\037', '\213', Z_DEFLATED, 0, 0, 0, 0,
0, 0, GF_CDC_OS_ID};
static const unsigned char gzip_header[10] = {
'\037', '\213', Z_DEFLATED, 0, 0, 0, 0, 0, 0, GF_CDC_OS_ID};

static int32_t
cdc_next_iovec(cdc_info_t *ci)
Expand Down