Address concurrency issue at resource_ended_at_normalization#1501
Merged
tobias-urdin merged 1 commit intoMay 8, 2026
Conversation
We discovered that the method "resource_ended_at_normalization" can be affected by a concurrency issue when multiple Gnocchi MetricD agents reach the same code at similar moments in time. As a consequence, we see multiple revisions being created in the resource, where the only change is the "ended_at" field. The multiple entries in the resource history are not a problem per se. However, it can create more load on the metadata DB that Gnocchi uses. This patch is addressing this situation by creating a lock mechanism, so multiple MetricD do not enter in the normalization part of the code together
tobias-urdin
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered that the method "resource_ended_at_normalization" can be affected by a concurrency issue when multiple Gnocchi MetricD agents reach the same code at similar moments in time. As a consequence, we see multiple revisions being created in the resource, where the only change is the "ended_at" field.
The multiple entries in the resource history are not a problem per se. However, it can create more load on the metadata DB that Gnocchi uses.
This patch is addressing this situation by creating a lock mechanism, so multiple MetricD do not enter in the normalization part of the code together