feat(tm2): add transfer event for bank ops#5361
Open
MikaelVallenet wants to merge 14 commits intognolang:masterfrom
Open
feat(tm2): add transfer event for bank ops#5361MikaelVallenet wants to merge 14 commits intognolang:masterfrom
MikaelVallenet wants to merge 14 commits intognolang:masterfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
davd-gzl
reviewed
Mar 26, 2026
davd-gzl
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bank module looks was ported with all event emission commented out.
Now that Gno has typed ABCI events (#4630), this PR wires them up.
Three event types are introduced:
TransferEvent— 1:1 transfers, carriesfrom,to,amountCoinSpentEvent— coins leaving an account (per-input in multi-send)CoinReceivedEvent— coins entering an account (per-output in multi-send)Using separate types for multi-send avoids zero-address sentinels that would confuse indexers. No event is emitted when the amount is zero.
partial fix #5344
Known limitations
runMsgs()creates afresh
EventLogger).sendCoins(), dedicatedMintEvent/BurnEventshould be introducedseparately.