Skip to content

feat(tm2): add transfer event for bank ops#5361

Open
MikaelVallenet wants to merge 14 commits intognolang:masterfrom
MikaelVallenet:feat/bank/emit-event
Open

feat(tm2): add transfer event for bank ops#5361
MikaelVallenet wants to merge 14 commits intognolang:masterfrom
MikaelVallenet:feat/bank/emit-event

Conversation

@MikaelVallenet
Copy link
Member

@MikaelVallenet MikaelVallenet commented Mar 25, 2026

Summary

The bank module looks was ported with all event emission commented out.
Now that Gno has typed ABCI events (#4630), this PR wires them up.

Three event types are introduced:

  • TransferEvent — 1:1 transfers, carries from, to, amount
  • CoinSpentEvent — coins leaving an account (per-input in multi-send)
  • CoinReceivedEvent — coins entering an account (per-output in multi-send)

Using separate types for multi-send avoids zero-address sentinels that would confuse indexers. No event is emitted when the amount is zero.

partial fix #5344

Known limitations

  • Gas fee transfers emit events but are not visible in tx results (ante handler runs before runMsgs() creates a
    fresh EventLogger).
  • Realm-level minting/burning bypasses sendCoins(), dedicated MintEvent/BurnEvent should be introduced
    separately.

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Mar 25, 2026
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Mar 25, 2026
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 25, 2026

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: MikaelVallenet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 User davd-gzl already reviewed PR 5361 with state APPROVED
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/sdk/bank/events.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 25, 2026
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Mar 26, 2026
@MikaelVallenet MikaelVallenet requested review from moul and thehowl March 26, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Notes on the event system.

3 participants