Add all domain masks to NSCoreServicesDirectory#576
Closed
pkgdemon wants to merge 1 commit intognustep:masterfrom
Closed
Add all domain masks to NSCoreServicesDirectory#576pkgdemon wants to merge 1 commit intognustep:masterfrom
pkgdemon wants to merge 1 commit intognustep:masterfrom
Conversation
Contributor
|
Thanks for looking at this, but you missed how the filesystem layout mechanism works: it's a lot more effort to implement the interaction between gnustep-make, default values, the configuration file etc and the runtime API. When I looked at this I realised that we already had the services variables in gnustep-make but had never completed their implementation by updating gnustep-base. |
Author
|
No problem. Thank you @rfm I will look over your commit more to see what I missed. It does look a lot more involved than what I thought indeed. Thanks for the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating per discussion from gnustep/tools-make#62