Skip to content

feat(webauthn): correct field naming#576

Draft
james-d-elliott wants to merge 1 commit intomasterfrom
feat-attestation-typefmt
Draft

feat(webauthn): correct field naming#576
james-d-elliott wants to merge 1 commit intomasterfrom
feat-attestation-typefmt

Conversation

@james-d-elliott
Copy link
Member

This corrects a long standing issue where the attestationType field actually held the attestationFormat value. Unfortunately this is a breaking change.

This corrects a long standing issue where the attestationType field actually held the attestationFormat value. Unfortunately this is a breaking change.
@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 34.09091% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.65%. Comparing base (fbb9a04) to head (d9a2056).

Files with missing lines Patch % Lines
protocol/attestation.go 40.00% 9 Missing ⚠️
webauthn/credential.go 41.66% 7 Missing ⚠️
webauthn/registration.go 0.00% 6 Missing ⚠️
protocol/credential.go 28.57% 4 Missing and 1 partial ⚠️
webauthn/login.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   52.71%   52.65%   -0.07%     
==========================================
  Files          40       40              
  Lines        2464     2467       +3     
==========================================
  Hits         1299     1299              
- Misses        951      954       +3     
  Partials      214      214              
Files with missing lines Coverage Δ
protocol/options.go 100.00% <ø> (ø)
webauthn/login_opt.go 100.00% <100.00%> (ø)
webauthn/registration_opt.go 100.00% <100.00%> (ø)
webauthn/login.go 38.19% <0.00%> (ø)
protocol/credential.go 31.08% <28.57%> (ø)
webauthn/registration.go 66.66% <0.00%> (-2.67%) ⬇️
webauthn/credential.go 10.76% <41.66%> (+1.39%) ⬆️
protocol/attestation.go 51.72% <40.00%> (-0.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant