Add the ability to cancel pan/zoom/orbit navigation#105791
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Mar 9, 2026
Merged
Add the ability to cancel pan/zoom/orbit navigation#105791Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
a0eb533 to
d2c925b
Compare
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
d2c925b to
a6955b0
Compare
Calinou
reviewed
Jul 8, 2025
Member
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Some feedback:
- When pressing the key/mouse button, navigation is canceled, but the pan/orbit/zoom will still be active. This means that if you move the mouse slightly afterwards, you will still result in some motion, which can be undesired. I think pressing the key/mouse button should exit the mode entirely until you press the key/mouse button that triggers the action again.
- This is particularly noticeable if you hold Escape while still trying to orbit:
navigation_cancel_hold_escape.mp4
60k41p
reviewed
Jul 9, 2025
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
a6955b0 to
eff2b73
Compare
Contributor
Author
|
Feedback addressed. |
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
eff2b73 to
e6855f5
Compare
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
e6855f5 to
afc5f31
Compare
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
afc5f31 to
c632127
Compare
github-project-automation
bot
moved this to For team assessment
in Usability Team Review Tracker
Member
|
This should also be added to the Game editor as well. Preferably by moving this code to the |
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
c632127 to
cdf533b
Compare
Contributor
Author
|
Done. I promise I'm going to stop forgetting about the game view from now on 😂 2026-03-08.19-47-00.mp4 |
Member
|
Would be possible to move the code for canceling it to inside the input handling of |
ryevdokimov
force-pushed
the
cancel-navigation
branch
from
cdf533b to
05c9155
Compare
Contributor
Author
|
Yeah, it can be done. |
github-project-automation
bot
moved this from For team assessment
to Merge Ready
in Usability Team Review Tracker
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with right click or escape key.
Demo:
2025-04-26.18-57-35.mp4