Refactor ShaderEditorPlugin to use ScriptEditor#115998
Open
TheDying0fLight wants to merge 1 commit intogodotengine:masterfrom
Open
Refactor ShaderEditorPlugin to use ScriptEditor#115998TheDying0fLight wants to merge 1 commit intogodotengine:masterfrom
ShaderEditorPlugin to use ScriptEditor#115998TheDying0fLight wants to merge 1 commit intogodotengine:masterfrom
Conversation
ba7b2a8 to
492d2c1
Compare
c027af8 to
2568c5a
Compare
d7ceb8c to
09df8e4
Compare
AThousandShips
approved these changes
Mar 5, 2026
Member
AThousandShips
left a comment
There was a problem hiding this comment.
Code looks good to me! Great work!
Haven't tested the functionality
7ba9f75 to
63f7dc7
Compare
63f7dc7 to
3ee514b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextEditorandScriptTextEditor#114917Changes
ShaderEditorPluginusing theScriptEditorclass used for theScriptEditorPluginShaderEditorclasses inherit fromScriptEditorBaseclassesScriptEditoris focused, because ofScriptEditorfocus loss when usingnext_script/prev_scriptshortcuts #117209 these sometimes stop working until an editor is focused again by clicking on itChanges that could be controversial
VisualShaderEditornow has a menu bar at the top reducing space. I did not find a nice way around this. If it stays this way the menu bar could be used for thetoggle_files_panel_buttonso it is at the same location for each editor type.Shader Editor(file and context) menus more similar to theScript Editormenus for more consistency between the editors and theShader Editormenus have a lot more options now.