Rendering shader compiler: remove unused variables#117116
Draft
ScatteredComet wants to merge 1 commit intogodotengine:masterfrom
Draft
Rendering shader compiler: remove unused variables#117116ScatteredComet wants to merge 1 commit intogodotengine:masterfrom
ScatteredComet wants to merge 1 commit intogodotengine:masterfrom
Conversation
ScatteredComet
changed the title
ScatteredComet
changed the title
ScatteredComet
force-pushed
the
projectsettings/cleanup
branch
from
c795f4e to
8ddbb29
Compare
Contributor
Author
|
I moved the change to |
these are unused since cf3f404
ScatteredComet
force-pushed
the
projectsettings/cleanup
branch
from
8ddbb29 to
7b3850b
Compare
Contributor
Author
|
I realise now that I should have run the bin with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectSettings.xmlappropriatelyDetails
The following 4 project settings:
all refer to variables whose logic was removed by #50847. As far as I can tell the variables created from these settings are unaccessed (
strip_debug.releaseis never accessed, the others are accessed but then placed into unused variables).