Allow resizing AnimationTree error panel#117432
Open
vaner-org wants to merge 1 commit intogodotengine:masterfrom
Open
Allow resizing AnimationTree error panel#117432vaner-org wants to merge 1 commit intogodotengine:masterfrom
vaner-org wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117427.
This PR moves the duplicated error panel code from
BlendSpace1D,BlendSpace2D,StateMachine, andBlendTree's editor plugins, and instead places it as part of a split container beneath each editor plugin's areas, in theAnimationTreedock itself. This is done to unify the state of the error panel which would previously flicker during navigation between node types, and allow the user to resize or hide it entirely, when active.animationtree-unify-error.mp4
If there issues with attempting a refactor, please let me know and I'll work around them. If there is interest in expanding the scope of this implementation to make it as mature as the Script Editor's error/warning displays, I'd be happy to do that too. It needs some kind of indicator when hidden, at least.