Silently stop all script debuggers if no debugging server is active#117434
Open
rsubtil wants to merge 1 commit intogodotengine:masterfrom
Open
Silently stop all script debuggers if no debugging server is active#117434rsubtil wants to merge 1 commit intogodotengine:masterfrom
rsubtil wants to merge 1 commit intogodotengine:masterfrom
Conversation
Co-authored-by: Krzysztof Biegański <krzysztof@biegan.ski>
|
I can't find an artifact for Linux to download to test? |
Member
Author
It should appear in the header bar at https://github.com/godotengine/godot/pull/117434/checks: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different approach from #114457 (cc @kbieganski)
May close #111175 (awaiting user feedback since I can't replicate it myself)
Instead of the original solution of always propagating the
stoppedsignal even when no debugger session was active (breaks DAP since it expects the signal to be emitted once and when a session is active), this approach does so only if the debug server is valid or the debugger session is active. If neither of those happen, then we still stop the debugging session but "internally", without propagating thestoppedsignal.(cc @m4gr3d due to f713a20 / #108518, just to double check this doesn't reintroduce an issue you fixed)