fix: Modern V8 requires two-stage GC#210
Merged
Benjamin-Dobell merged 1 commit intogodotjs:mainfrom Apr 20, 2026
Merged
Conversation
Member
Author
|
Whoops, ffbade0 indicates it implements the work found in this PR. It was originally part of that commit and I pulled it out here separately. |
Benjamin-Dobell
changed the title
Benjamin-Dobell
force-pushed
the
feat/modern-v8
branch
from
8eb5116 to
771bb70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern V8 split their GC callbacks into 2 phases, actually the second phase is optional. The idea is that GC callbacks (in the first phase) are restricted to extremely light work — basically just
Reset()the handle. When more expensive work is required (which it is in our case) then you must request a second phase callback.