fix: filter newline#2526
Conversation
CatsDeservePets
left a comment
There was a problem hiding this comment.
Please also filter these out before writing marks and tags.
Thanks for catching that. I was contemplating this for a while, but I also added an error log instead of just skipping the file, so at least its in the logs. Ui error display did not seem appropriate for these functiosn though. I would like some feedback on the approach for now. |
Better not, this would mess up my logs due to macOS having
Sorry for not replying earlier. I had some stressful days. I could not come up with a 'better' solution here, so I think this is fine. |
Take as much time as you need. I already feel bad for all the PRs anyway |
|
If you have nothing to add, I'd merge it. |
|
Nothing more to add, ready to be merged |
we are using newline as a delimiter, so we cant have this in filenames