fix: deadlock in Measurements.close()#246
Open
manaspros wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
fix: deadlock in Measurements.close()#246manaspros wants to merge 1 commit intogoogle-deepmind:mainfrom
manaspros wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close()holds_channels_lockand then callsclose_channel(), which tries to acquire the same lock again. Sincethreading.Lockis not reentrant this deadlocks immediately.Also, iterating
self._channelswhileclose_channeldeletes from it raisesRuntimeError: dictionary changed size during iteration.Fix: replace the loop with a direct
self._channels.clear()inside the existing lock, which is both correct and simpler. Added tests including a regression for the deadlock.