Add schema-validating policy helpers for tool runtime#252
Open
gut-puncture wants to merge 4 commits intogoogle-deepmind:mainfrom
Open
Add schema-validating policy helpers for tool runtime#252gut-puncture wants to merge 4 commits intogoogle-deepmind:mainfrom
gut-puncture wants to merge 4 commits intogoogle-deepmind:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds schema helper support for tool policies and integrates it with the current tool runtime.
Changes:
validate_input_schema(args, schema) -> str | Noneinconcordia/document/tool_policy.pySchemaValidatingPolicy(delegate: ToolPolicy | None = None)This branch is intentionally independently mergeable from
main, so it includes the core runtime hardening required by these helpers.Why
Tool.input_schemametadata existed but lacked a first-class, minimal helper path. This PR makes it practically useful without changing default behavior.Test Coverage
Validation
Executed locally:
. .venv/bin/activate && python -m pytest -q concordia/document/tool_policy_test.py. .venv/bin/activate && python -m pytest -q concordia/document/interactive_document_tools_test.py. .venv/bin/activate && python -m pytest -q concordia/document. .venv/bin/activate && python -m pylint --errors-onlyon touched files